There are no needs to call this subroutine inside a loop (bug 16157 has removed the selected flag).
Created attachment 49644 [details] [review] Bug 16158: Move GetAuthorisedValues outside the loop In catalogue/detail.pl and catalogue/moredetail.pl, the GetAuthorisedValues subroutine is called once per item. It's not needed, only 1 call is enough. Test plan: Edit item and view a catalogue record. The withdrawn, lost and damaged values should be correctly displayed/saved.
(In reply to Jonathan Druart from comment #0) > There are no needs to call this subroutine inside a loop (bug 16157 has > removed the selected flag). Agreed. The Authorized Value Name for the item fields isn't going to change, since the Biblio is the same which keeps the framework code the same.
Please rebase.
(In reply to M. Tompsett from comment #3) > Please rebase. Apply cleanly on top of bug 16157.
(In reply to Jonathan Druart from comment #4) > (In reply to M. Tompsett from comment #3) > > Please rebase. > > Apply cleanly on top of bug 16157. DOH! Sorry, I missed that. It does.
Created attachment 49959 [details] [review] Bug 16158: Move GetAuthorisedValues outside the loop In catalogue/detail.pl and catalogue/moredetail.pl, the GetAuthorisedValues subroutine is called once per item. It's not needed, only 1 call is enough. Test plan: Edit item and view a catalogue record. The withdrawn, lost and damaged values should be correctly displayed/saved. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 50048 [details] [review] Bug 16158: Move GetAuthorisedValues outside the loop In catalogue/detail.pl and catalogue/moredetail.pl, the GetAuthorisedValues subroutine is called once per item. It's not needed, only 1 call is enough. Test plan: Edit item and view a catalogue record. The withdrawn, lost and damaged values should be correctly displayed/saved. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 Release. Thanks!