Bug 16162 - Making dictionary 'Delete' a font awesome button
Summary: Making dictionary 'Delete' a font awesome button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 16161
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-29 23:44 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16162: Making dictionary 'Delete' a button (1.88 KB, patch)
2016-03-29 23:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16162: Making dictionary 'Delete' a button (1.99 KB, patch)
2016-03-31 04:52 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16162: Making dictionary 'Delete' a button (2.12 KB, patch)
2016-03-31 05:46 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16162: Making dictionary 'Delete' a button (2.43 KB, patch)
2016-03-31 21:48 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16162: Making dictionary 'Delete' a button (2.46 KB, patch)
2016-04-02 08:03 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16162: Making dictionary 'Delete' a button (2.52 KB, patch)
2016-04-03 12:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-29 23:44:52 UTC

    
Comment 1 Aleisha Amohia 2016-03-29 23:47:35 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-30 08:39:45 UTC
QA tools complain:
 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 82)
		forbidden pattern: tab char (line 71)
		forbidden pattern: tab char (line 79)
Comment 3 Aleisha Amohia 2016-03-31 04:52:30 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-03-31 05:46:21 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-03-31 13:07:49 UTC
Aleisha, please submit a followup on top of bug 16161
Comment 6 Aleisha Amohia 2016-03-31 21:48:00 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-04-02 08:03:31 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2016-04-03 12:52:05 UTC
Created attachment 49819 [details] [review]
[PASSED QA] Bug 16162: Making dictionary 'Delete' a button

EDIT: This patch should have gotten rid of those tabs
EDIT2: Will now apply with patch on Bug 16161

To test:
1) Apply Bug 16161 first
2) Go to Reports -> View dictionary
3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button.
4) Confirm that the button does not wrap on narrower browsers.
5) Confirm that column heading is now 'Action'.
6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.)

Sponsored-by: Catalyst IT

Tested on top of Bug 16161
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Brendan Gallagher 2016-04-07 00:10:15 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!