Bug 16186 - t/db_dependent/Circulation_Issuingrule.t is failing
Summary: t/db_dependent/Circulation_Issuingrule.t is failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-01 14:18 UTC by Mark Tompsett
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing (3.25 KB, patch)
2016-04-01 14:38 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing (3.30 KB, patch)
2016-04-01 15:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2016-04-01 14:18:56 UTC
Bug 5786 changed the query for GetIssuingRules to SELECT *, which means if columns are added to the DB, this breaks.

Add missing column(s) into the issuing rules hashes in the test.
Comment 1 Mark Tompsett 2016-04-01 14:38:59 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2016-04-01 15:11:52 UTC
Created attachment 49796 [details] [review]
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing

TEST PLAN
---------
1) prove t/db_dependent/Circulation_Issuingrule.t
   -- fails
2) apply patch
3) prove t/db_dependent/Circulation_Issuingrule.t
   -- pass
4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t
   -- notice that bug 5876 and bug 9129 combined to cause this
5) run koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Comment 3 Tomás Cohen Arazi 2016-04-01 15:13:07 UTC
Trivial fix for the tests.
Comment 4 Brendan Gallagher 2016-04-01 18:46:13 UTC
Pushed to Master - Should be in the 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-06 13:23:32 UTC
Not needed in stable versions, status changed to RESOLVED