Bug 16194 - Do not consider xslt as valid theme dir in LangInstaller.pm
Summary: Do not consider xslt as valid theme dir in LangInstaller.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 13:51 UTC by Bernardo Gonzalez Kriegel
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm (1.50 KB, patch)
2016-04-04 14:00 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm (1.58 KB, patch)
2016-04-04 14:30 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm (1.65 KB, patch)
2016-04-04 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2016-04-04 13:51:58 UTC
Bug 15527 adds a new dir 'xslt' in opac-tmpl, and it's considered as a theme dir.

perl translate update es-ES
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
Comment 1 Bernardo Gonzalez Kriegel 2016-04-04 14:00:19 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2016-04-04 14:30:50 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-04 21:34:15 UTC
Created attachment 49881 [details] [review]
[PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-04-05 15:18:41 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-07 08:22:58 UTC
Not needed in stable versions, status changed to RESOLVED