The fee entry for 'hold waiting too long' creates an accountlines entry containing untranslatable text and using an F fee type. It would be better to have use a unique fee type that can be used to show a translated entry in the GUI. CancelReserve(): manualinvoice($reserve->{'borrowernumber'}, $reserve->{'itemnumber'}, 'Hold waiting too long', 'F', $charge); Shows in the German GUI as: Mahngebühr , Hold waiting too long 130251 Medium ansehen Physik in Demonstrationsversuchen.
Created attachment 51571 [details] [review] Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated
Created attachment 51572 [details] [review] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this bug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated
Thx Lari!
*** Bug 11387 has been marked as a duplicate of this bug. ***
Created attachment 51574 [details] [review] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this bug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated
Created attachment 51589 [details] [review] Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Created attachment 51590 [details] [review] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Created attachment 51605 [details] [review] [PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
What happened to the first patch "Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype"?
Ah, I am sorry. I missed the second patch when signing off and reattaching. Please feel free to fix - or I will do it tonight.
Created attachment 51631 [details] [review] [PASSED QA] Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 51632 [details] [review] [PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the November Release. Thanks!
Pushed in 16.05. Will be in 16.05.01.
Patches pushed to 3.22.x, will be in 3.22.8