Bug 16205 - MARC editor settings menu should use a Font Awesome icon
Summary: MARC editor settings menu should use a Font Awesome icon
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/addbiblio.pl
Keywords:
Depends on: 15859
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-05 15:56 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16205 - MARC editor settings menu should use a Font Awesome icon (1.59 KB, patch)
2016-04-05 15:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16205: MARC editor settings menu should use a Font Awesome icon (1.62 KB, patch)
2016-04-05 16:42 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16205 - MARC editor settings menu should use a Font Awesome icon (1.70 KB, patch)
2016-04-05 17:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-05 15:56:00 UTC
The new MARC editor settings menu uses a Glyphicon. It should use a Font Awesome icon instead.
Comment 1 Owen Leonard 2016-04-05 15:59:42 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-05 16:42:04 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2016-04-05 17:20:30 UTC
Created attachment 49923 [details] [review]
Bug 16205 - MARC editor settings menu should use a Font Awesome icon

When I added the MARC editor settings menu in Bug 15859 I accidentally
used a Glyphicon. This patch corrects it to use a Font Awesome icon.

To test, apply the patch and open the basic cataloging editor. The
"Settings" menu should use a Font Awesome icon instead of a Glyphicon.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Icons changed
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Works as expected, no qa errors
Comment 4 Brendan Gallagher 2016-04-06 23:58:49 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!