In testing the new EDI pages I tried adding a "Library EAN" with no fields filled out (other than the pre-filled options). The record saved successfully with empty values for EAN and description. When I went to test deletion of one of these records I got an error: Can't call method "delete" on an undefined value at /admin/edi_ean_accounts.pl line 112. I notice the link to delete passes the ean value (which is empty in my test): /admin/edi_ean_accounts.pl?op=delete_confirm&branchcode=APL&ean= I assume this is the reason for the error. If the edifact_ean table has a primary key (ee_id), why not use that for deletion? Should the EAN field be required?
Created attachment 50355 [details] [review] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to
Created attachment 50356 [details] [review] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to
Bug 16206, "Corrections to templates related new EDI feature" is Passed QA. Could this patch be rebased on top of that?
Created attachment 50367 [details] [review] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first
Created attachment 50380 [details] [review] [PASSED QA] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=16256
I am sorry... but I just noticed: it didn't delete! When confirming yes, nothing happens. From the logs: [Tue Apr 19 07:49:37.687937 2016] [cgi:error] [pid 17497] [client 127.0.0.1:37847] AH01215: [Tue Apr 19 07:49:37 2016] edi_ean_accounts.pl: DBIx::Class::ResultSet::_build_unique_cond(): NULL/undef values supplied for requested unique constraint 'primary' (NULL values in column(s): 'ee_id'). This is almost certainly not what you wanted, though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning. at /home/katrin/kohaclone/admin/edi_ean_accounts.pl line 140, referer: http://localhost:8080/cgi-bin/koha/admin/edi_ean_accounts.pl
Looking at the form for confirming deletion shows the hidden value for ean to be still empty: <input type="hidden" name="ean" value="" />
Created attachment 50394 [details] [review] Bug 16208 [QA Followup] - Fix incorrect form parameter names
Created attachment 50445 [details] [review] [PASSED QA] Bug 16208 - Can't delete a library EAN if the EAN value is empty Test Plan: 1) Create an empty EAN 2) Attempt to delete it, you should get an error 3) Apply this patch 4) Attempt to delete the EAN, you should now be able to Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> This depends on bug 16206 being pushed, or you need to apply that patch first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=16256 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 50446 [details] [review] [PASSED QA] Bug 16208 [QA Followup] - Fix incorrect form parameter names Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Not needed in stable versions, status changed to RESOLVED