From commit 1538e9ecf47642c4974693ff499c3e95e4d71977 Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search """ Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) """ Well, it's not hard to change, but the commit was wrong. The expected behaviors are: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order
Created attachment 50067 [details] [review] Bug 16227: Fix regression from bug 15084 - select currencies correctly This patch fixes a regression introduced by bug 15084: The currency dropdown lists are not correctly built. The selected currencies are wrong. Test plan: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order
Created attachment 50150 [details] [review] [SIGNED-OFF] Bug 16227: Fix regression from bug 15084 - select currencies correctly This patch fixes a regression introduced by bug 15084: The currency dropdown lists are not correctly built. The selected currencies are wrong. Test plan: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 50219 [details] [review] [PASSED QA] Bug 16227: Fix regression from bug 15084 - select currencies correctly This patch fixes a regression introduced by bug 15084: The currency dropdown lists are not correctly built. The selected currencies are wrong. Test plan: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Not needed in stable versions, status changed to RESOLVED