Marked as bug because the behavior is confusing (shows empty record but saves over old record).
Any updates Carnegie Team
It looks like the current record is opened instead of a 'copy' of it that will save as new. This can cause unwanted data loss, updating severity.
Created attachment 88401 [details] [review] Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie
Created attachment 88617 [details] [review] Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 88618 [details] [review] Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
missing dependency for 18.05.x, no backport
This give me a new "undefined" value in save target list. What is it supposed to be ? Clicking on it simply save the record in database, like if i just click on "Save to catalog".