Bug 16233 - Unclosed <strong> tag in the opac-facets.inc breaks some display
Summary: Unclosed <strong> tag in the opac-facets.inc breaks some display
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-10 22:10 UTC by Chris Cormack
Modified: 2016-12-05 21:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16233 Unclosed <strong> in opac-facets.inc (1.69 KB, patch)
2016-04-10 22:12 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 16233 Unclosed <strong> in opac-facets.inc (1.73 KB, patch)
2016-04-11 03:42 UTC, Mark Tompsett 		Details | Diff | Splinter Review
[PASSED QA] Bug 16233 Unclosed <strong> in opac-facets.inc (1.80 KB, patch)
2016-04-11 05:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2016-04-10 22:10:01 UTC 
There are 2 <strong> tags in the availability section of opac-facets.inc

So if you restrict by availability you get some odd display issues on the search results screen
Comment 1 Chris Cormack 2016-04-10 22:12:12 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-04-11 03:35:30 UTC 
Comment on attachment 50099 [details] [review]
Bug 16233 Unclosed <strong> in opac-facets.inc

Review of attachment 50099 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
@@ -6,4 @@
>                  <ul>
>                      <li>
>                          [% IF ( available ) %]
> -                            <strong>Showing only available items<strong></li><li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&amp;sort_by=[% sort_by |url %][% END %]">Show all items</a>

Good catch! Just a single / missing to close the tag.
Comment 3 Mark Tompsett 2016-04-11 03:42:06 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-04-11 05:55:52 UTC 
Created attachment 50110 [details] [review]
[PASSED QA] Bug 16233 Unclosed <strong> in opac-facets.inc

To test:
1/ Do a search in the OPAC
2/ Restrict to only available items
3/ Notice the authors now appear bold
4/ Apply patch
5/ Refresh the page
6/ Authors should now look normal again

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-04-22 22:56:13 UTC 
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-05-16 11:21:33 UTC 
Patch pushed to 3.22.x, will be in 3.22.7