Created attachment 50102 [details] [review] Bug 16235: Making borrower account actions buttons To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT
Created attachment 50137 [details] [review] Bug 16235: Making borrower account actions buttons To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Testing highlighted issues with 'Reverse' not caused by this patched.
Created attachment 50139 [details] screenshot Hi Aleisha, buttons seem to wrap quite early - can you please check?
Created attachment 50247 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt FAIL forbidden patterns forbidden pattern: tab char (line 114) forbidden pattern: tab char (line 112) forbidden pattern: tab char (line 122)
Created attachment 50300 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 50305 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch>
Aleisha, If reverse_col is not set, the th will have a colspan of 1 and the targets (-1, -2) will be wrong. The right way is to use a class (NoSort), see acqui/newordersubscription.tt for an example. Why don't you put the 2 buttons into the same cell? To keep the alignment?
Created attachment 50545 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EIDT: Moving the buttons into one column To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch>
This latest version triggers a JavaScript error because the count of table cells in the footer is off. I also notice on line 72 " " without a ;
Created attachment 50684 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch>
Sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt FAIL forbidden patterns forbidden pattern: tab char (line 118) forbidden pattern: tab char (line 120)
Created attachment 50770 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 50793 [details] [review] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Followed test plan. White spaces OK. Signed-off-by: Marc Véron <veron@veron.ch>
HTML validator has a few complaints about the page, but none seem related to the patch - maybe something to look into for another day and bug report :)
Created attachment 50794 [details] [review] [PASSED QA] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Followed test plan. White spaces OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master. Should be in the May 2016 release! Toda Aleisha!