Bug 16235 - Making borrower account actions buttons
Summary: Making borrower account actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 02:10 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16235: Making borrower account actions buttons (3.55 KB, patch)
2016-04-11 02:14 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (3.60 KB, patch)
2016-04-12 00:46 UTC, Mark Tompsett
Details | Diff | Splinter Review
screenshot (13.99 KB, image/png)
2016-04-12 06:27 UTC, Katrin Fischer
Details
Bug 16235: Making borrower account actions buttons (4.15 KB, patch)
2016-04-14 21:36 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.19 KB, patch)
2016-04-17 22:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.32 KB, patch)
2016-04-18 07:43 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.52 KB, patch)
2016-04-21 22:24 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.82 KB, patch)
2016-04-25 21:55 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.85 KB, patch)
2016-04-27 00:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16235: Making borrower account actions buttons (4.89 KB, patch)
2016-04-27 10:50 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16235: Making borrower account actions buttons (4.96 KB, patch)
2016-04-27 11:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-11 02:10:09 UTC

    
Comment 1 Aleisha Amohia 2016-04-11 02:14:40 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-04-12 00:46:40 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2016-04-12 00:48:46 UTC
Testing highlighted issues with 'Reverse' not caused by this patched.
Comment 4 Katrin Fischer 2016-04-12 06:27:22 UTC
Created attachment 50139 [details]
screenshot

Hi Aleisha, 

buttons seem to wrap quite early - can you please check?
Comment 5 Aleisha Amohia 2016-04-14 21:36:59 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2016-04-15 12:35:12 UTC
Sorry, QA tools complain:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 114)
		forbidden pattern: tab char (line 112)
		forbidden pattern: tab char (line 122)
Comment 7 Aleisha Amohia 2016-04-17 22:07:37 UTC Comment hidden (obsolete)
Comment 8 Marc Véron 2016-04-18 07:43:39 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-04-18 10:47:48 UTC
Aleisha,
If reverse_col is not set, the th will have a colspan of 1 and the targets (-1, -2) will be wrong.
The right way is to use a class (NoSort), see acqui/newordersubscription.tt for an example.
Why don't you put the 2 buttons into the same cell? To keep the alignment?
Comment 10 Aleisha Amohia 2016-04-21 22:24:38 UTC Comment hidden (obsolete)
Comment 11 Owen Leonard 2016-04-22 01:05:53 UTC
This latest version triggers a JavaScript error because the count of table cells in the footer is off.

I also notice on line 72 "&nbsp" without a ;
Comment 12 Aleisha Amohia 2016-04-25 21:55:47 UTC Comment hidden (obsolete)
Comment 13 Marc Véron 2016-04-26 04:34:40 UTC
Sorry, QA tools complain:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 118)
		forbidden pattern: tab char (line 120)
Comment 14 Aleisha Amohia 2016-04-27 00:22:56 UTC Comment hidden (obsolete)
Comment 15 Marc Véron 2016-04-27 10:50:29 UTC Comment hidden (obsolete)
Comment 16 Katrin Fischer 2016-04-27 11:02:33 UTC
HTML validator has a few complaints about the page, but none seem related to the patch - maybe something to look into for another day and bug report :)
Comment 17 Katrin Fischer 2016-04-27 11:03:18 UTC
Created attachment 50794 [details] [review]
[PASSED QA] Bug 16235: Making borrower account actions buttons

EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap
EDIT: Comment 6
EDIT: Moving the buttons into one column
EDIT: Fixing typo and js error
EDIT: removing tabs

To test:
1) Go to a borrower's account page who has paid fines before
	a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column
	b) Confirm Reverse and Print show as buttons and work as expected
2) Go to a borrower's account page who has never paid fines (or create a new borrower)
	a) Create a manual credit (just to put something in their account)
	b) Go back to their account page
	c) Confirm the Reverse column does not show as the column heading for Print is   (since there is only one action in this column and it's written on every button)
	d) Confirm Print shows as a button and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Followed test plan. White spaces OK.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 18 Kyle M Hall 2016-04-29 11:04:54 UTC
Pushed to master. Should be in the May 2016 release! Toda Aleisha!