Bug 16236 - Making authorised values actions buttons
Summary: Making authorised values actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 02:19 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16236: Making authorised values actions buttons (1.84 KB, patch)
2016-04-11 02:20 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16236: Making authorised values actions buttons (1.89 KB, patch)
2016-04-11 03:24 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16236: Whitespace followup (1.15 KB, patch)
2016-04-11 03:24 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16236: Making authorised values actions buttons (1.97 KB, patch)
2016-04-11 07:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16236: Whitespace followup (1.22 KB, patch)
2016-04-11 07:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-11 02:19:19 UTC

    
Comment 1 Aleisha Amohia 2016-04-11 02:20:43 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-04-11 03:24:28 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2016-04-11 03:24:33 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2016-04-11 03:25:07 UTC
White space follow up seems trivial enough to push this to signed off.
Comment 5 Jonathan Druart 2016-04-11 07:34:38 UTC
Created attachment 50116 [details] [review]
Bug 16236: Making authorised values actions buttons

To test:
1) Go to Admin -> Authorised values
2) Select a category
3) Confirm that Edit and Delete shows as buttons under 'Actions' column and work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-04-11 07:34:42 UTC
Created attachment 50117 [details] [review]
Bug 16236: Whitespace followup

tab to 4 spaces on line 255, as per koha qa test tool failure
without this patch.

TEST PLAN
---------
1) Apply first patch
2) Run koha qa test tools
   -- fails because of a tab
3) Apply this patch
4) Run koha qa test tools
   -- passes

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Kyle M Hall 2016-04-29 11:06:35 UTC
Pushed to master! Should be in the May 2016 release. Sukria Aleisha!