Bug 16246 - Return all reserves columns in ILS-DI GetRecords response
Summary: Return all reserves columns in ILS-DI GetRecords response
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-12 12:24 UTC by Julian Maurice
Modified: 2018-12-03 20:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16246: Return all reserves columns in ILS-DI GetRecords response (1.71 KB, patch)
2016-04-12 12:25 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Add tests for ILS-DI GetRecords (5.73 KB, patch)
2016-04-12 12:25 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Return all reserves columns in ILS-DI GetRecords response (1.69 KB, patch)
2016-10-25 07:53 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Add tests for ILS-DI GetRecords (2.38 KB, patch)
2016-10-25 07:53 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Return all reserves columns in ILS-DI GetRecords response (1.69 KB, patch)
2017-03-13 12:51 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Add tests for ILS-DI GetRecords (2.41 KB, patch)
2017-03-13 12:51 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 16246: Return all reserves columns in ILS-DI GetRecords response (1.74 KB, patch)
2017-03-20 16:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 16246: Add tests for ILS-DI GetRecords (2.46 KB, patch)
2017-03-20 16:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-04-12 12:24:34 UTC
The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table
Comment 1 Julian Maurice 2016-04-12 12:25:20 UTC
Created attachment 50143 [details] [review]
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table
Comment 2 Julian Maurice 2016-04-12 12:25:23 UTC
Created attachment 50144 [details] [review]
Bug 16246: Add tests for ILS-DI GetRecords

+ remove some warnings in C4/ILSDI/Services.pm
Comment 3 Julian Maurice 2016-04-12 12:31:08 UTC
Test plan:

1. Go to http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of a record that have at least one hold.
2. Confirm that you have all non-NULL fields displayed in //record/reserves/reserve (compare with what you have in DB)
3. prove t/db_dependent/ILSDI_Services.t
Comment 4 Andreas Hedström Mace 2016-08-11 19:49:02 UTC
Patch did not apply for me. Needs a rebase?
Comment 5 Julian Maurice 2016-10-25 07:53:37 UTC
Created attachment 56829 [details] [review]
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table
Comment 6 Julian Maurice 2016-10-25 07:53:43 UTC
Created attachment 56830 [details] [review]
Bug 16246: Add tests for ILS-DI GetRecords
Comment 7 Julian Maurice 2016-10-25 07:54:01 UTC
Patches rebased on master
Comment 8 Julian Maurice 2017-03-13 12:51:52 UTC
Created attachment 61032 [details] [review]
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table
Comment 9 Julian Maurice 2017-03-13 12:51:55 UTC
Created attachment 61033 [details] [review]
Bug 16246: Add tests for ILS-DI GetRecords
Comment 10 Julian Maurice 2017-03-13 12:52:10 UTC
Patches rebased on master
Comment 11 Biblibre Sandboxes 2017-03-20 16:13:13 UTC
Patch tested with a sandbox, by Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Comment 12 Biblibre Sandboxes 2017-03-20 16:13:41 UTC
Created attachment 61329 [details] [review]
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Comment 13 Biblibre Sandboxes 2017-03-20 16:13:44 UTC
Created attachment 61330 [details] [review]
Bug 16246: Add tests for ILS-DI GetRecords

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Comment 14 Koha Team University Lyon 3 2017-03-20 16:21:21 UTC
Tried with several holds : they are all displayed in the XML file produced by http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX with the same values than in DB (check by a SQL report)
There's no NULL value.
When we change an information, XML produced by ILSDI is updated.

cf :
<reserves><reserve><timestamp>2017-03-20 17:06:29</timestamp><borrowernumber>4024</borrowernumber><reserve_id>1424</reserve_id><biblionumber>979</biblionumber><reservedate>2017-03-20</reservedate><suspend>1</suspend><lowestPriority>0</lowestPriority><rtimestamp>2017-03-20 17:06:29</rtimestamp><priority>1</priority><suspend_until>2017-03-22 00:00:00</suspend_until><branchcode>MAURES</branchcode><reservenotes/></reserve><reserve><biblionumber>979</biblionumber><lowestPriority>1</lowestPriority><suspend>0</suspend><reservedate>2017-03-20</reservedate><borrowernumber>6128</borrowernumber><timestamp>2017-03-20 17:06:29</timestamp><reserve_id>1425</reserve_id><reservenotes>test</reservenotes><branchcode>MAURES</branchcode><priority>2</priority><rtimestamp>2017-03-20 17:06:29</rtimestamp></reserve></reserves>
Comment 15 Jonathan Druart 2017-03-21 12:01:31 UTC
Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber.

See patch:  Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds

I needed to create a new method, Koha::Holds->search is not identical as GetReservesFromBiblionumber.

Your patch will introduce a change with existing behaviour that does not look expected.
Comment 16 Julian Maurice 2018-02-06 13:52:24 UTC
(In reply to Jonathan Druart from comment #15)
> Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber.

Bug 17736 also removed completely the usefulness of this bug :)
Changing status to RESOLVED