The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table
Created attachment 50143 [details] [review] Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table
Created attachment 50144 [details] [review] Bug 16246: Add tests for ILS-DI GetRecords + remove some warnings in C4/ILSDI/Services.pm
Test plan: 1. Go to http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of a record that have at least one hold. 2. Confirm that you have all non-NULL fields displayed in //record/reserves/reserve (compare with what you have in DB) 3. prove t/db_dependent/ILSDI_Services.t
Patch did not apply for me. Needs a rebase?
Created attachment 56829 [details] [review] Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table
Created attachment 56830 [details] [review] Bug 16246: Add tests for ILS-DI GetRecords
Patches rebased on master
Created attachment 61032 [details] [review] Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table
Created attachment 61033 [details] [review] Bug 16246: Add tests for ILS-DI GetRecords
Patch tested with a sandbox, by Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Created attachment 61329 [details] [review] Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Created attachment 61330 [details] [review] Bug 16246: Add tests for ILS-DI GetRecords Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Tried with several holds : they are all displayed in the XML file produced by http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX with the same values than in DB (check by a SQL report) There's no NULL value. When we change an information, XML produced by ILSDI is updated. cf : <reserves><reserve><timestamp>2017-03-20 17:06:29</timestamp><borrowernumber>4024</borrowernumber><reserve_id>1424</reserve_id><biblionumber>979</biblionumber><reservedate>2017-03-20</reservedate><suspend>1</suspend><lowestPriority>0</lowestPriority><rtimestamp>2017-03-20 17:06:29</rtimestamp><priority>1</priority><suspend_until>2017-03-22 00:00:00</suspend_until><branchcode>MAURES</branchcode><reservenotes/></reserve><reserve><biblionumber>979</biblionumber><lowestPriority>1</lowestPriority><suspend>0</suspend><reservedate>2017-03-20</reservedate><borrowernumber>6128</borrowernumber><timestamp>2017-03-20 17:06:29</timestamp><reserve_id>1425</reserve_id><reservenotes>test</reservenotes><branchcode>MAURES</branchcode><priority>2</priority><rtimestamp>2017-03-20 17:06:29</rtimestamp></reserve></reserves>
Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber. See patch: Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds I needed to create a new method, Koha::Holds->search is not identical as GetReservesFromBiblionumber. Your patch will introduce a change with existing behaviour that does not look expected.
(In reply to Jonathan Druart from comment #15) > Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber. Bug 17736 also removed completely the usefulness of this bug :) Changing status to RESOLVED