Moving the actions for authority framework tags into a drop down menu Making the Delete action for subfields a font awesome button
Created attachment 50248 [details] [review] Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT
Created attachment 50274 [details] Menu gets cut off if browser window isn't very wide Could you switch <ul class="dropdown-menu pull-left" to <ul class="dropdown-menu pull-right" ? That would keep the menu from popping up off the page in cases where the browser window isn't at least 1520px wide or so.
Created attachment 50302 [details] [review] Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT
We need to make <ul class="dropdown-menu pull-left" to <ul class="dropdown-menu pull-right" at line 167 as Owen pointed out.
(In reply to Arslan Farooq from comment #4) > We need to make > <ul class="dropdown-menu pull-left" > > to > > <ul class="dropdown-menu pull-right" > > at line 167 as Owen pointed out. I did make this change?
The latest patch removes "pull-right" from authtypes.tt but doesn't add it to auth_tag_structure.tt.
(In reply to Owen Leonard from comment #6) > The latest patch removes "pull-right" from authtypes.tt but doesn't add it > to auth_tag_structure.tt. Sorry, I misunderstood. Making changes now
Created attachment 50671 [details] [review] Bug 16263: making authority tags and subfields actions buttons To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT
Hi, The patch works fine. Everything looks OK. However the qa tools fails. It says: http://paste.koha-community.org/419 Note: I made sure master branch was up to date. And tested the patch on a fresh checked out branch.
> > However the qa tools fails. It says: http://paste.koha-community.org/419 > No fails for me $ qa -c 1 testing 1 commit(s) (applied to 9648cd2 'Bug 12267 - Update DB Schema files') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
Created attachment 50705 [details] [review] Bug 16263: making authority tags and subfields actions buttons After applying patch, everything looked OK in staff client. But the QA tools are complaining about something: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template
(In reply to Arslan Farooq from comment #11) > FAIL valid_template > Attempt to reload Koha/Template/Plugin/Koha.pm aborted. > Compilation failed in require at > /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. I get this error all the time and I've always assumed that it's because I'm testing in a gitified package installation. What kind of test system are you working with?
Thanks Owen. I also tested on gitified Koha installation...using Vagrant.
I am not sure about the "i" symbol for showing the subfields list - why not use the "eye" as we have in other places? Thanks for fixing 'subfields' - that was bugging me since forever!
Created attachment 50773 [details] [review] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com>
Created attachment 50781 [details] [review] [SIGNED-OFF] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Another sign, pretty eye. No errors.
Created attachment 50787 [details] [review] [PASSED QA] Bug 16263: making authority tags and subfields actions buttons EDIT: Subfields icon, 'i' to eye To test: 1) Go to Admin -> Authority types 2) Click the dropdown for one of the frameworks and click MARC structure 3) Confirm the actions subfields, edit and delete all show in the dropdown and work as expected 4) Click subfields 5) Confirm the action delete on this page shows as a font awesome button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Another sign, pretty eye. No errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master, should be in the May 2016 release! Kamsa hamnida Aleisha!