Created attachment 50251 [details] [review] Bug 16267: Making circ and fines rules actions buttons To test: 1) Go to Admin -> Circulation and fines rules 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT
Created attachment 50252 [details] [review] Bug 16267: Making circ and fines rules actions buttons To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT
Works fine, but sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL forbidden pattern: tab char (line 256)
Created attachment 50299 [details] [review] Bug 16267: Making circ and fines rules actions buttons EDIT: Comment 3 To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT
Created attachment 50304 [details] [review] Bug 16267: Making circ and fines rules actions buttons EDIT: Comment 3 To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch>
These steps worked: -------------- To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser -------------- And QA tools passed: -------------- Processing files after patches |========================>| 1 / 1 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template --------------
Created attachment 50306 [details] [review] Making circ and fines rules actions buttons These steps worked: -------------- To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser -------------- And QA tools passed: -------------- Processing files after patches |========================>| 1 / 1 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template --------------
Created attachment 50320 [details] [review] Bug 16267: Making circ and fines rules actions buttons EDIT: Comment 3 To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, should be in the May 2016 release! Tak Aleisha!