Bug 16267 - Making circ and fines rules actions buttons
Summary: Making circ and fines rules actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16268
  Show dependency treegraph
 
Reported: 2016-04-14 22:30 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16267: Making circ and fines rules actions buttons (5.15 KB, patch)
2016-04-14 22:42 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16267: Making circ and fines rules actions buttons (7.80 KB, patch)
2016-04-14 22:55 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16267: Making circ and fines rules actions buttons (7.86 KB, patch)
2016-04-17 22:05 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16267: Making circ and fines rules actions buttons (7.99 KB, patch)
2016-04-18 07:37 UTC, Marc Véron
Details | Diff | Splinter Review
Making circ and fines rules actions buttons (7.93 KB, patch)
2016-04-18 07:53 UTC, Arslan Farooq
Details | Diff | Splinter Review
Bug 16267: Making circ and fines rules actions buttons (7.98 KB, patch)
2016-04-18 10:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-14 22:30:58 UTC

    
Comment 1 Aleisha Amohia 2016-04-14 22:42:46 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-04-14 22:55:35 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-04-15 09:38:54 UTC
Works fine, but sorry, QA tools complain:

FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
FAIL	forbidden pattern: tab char (line 256)
Comment 4 Aleisha Amohia 2016-04-17 22:05:41 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2016-04-18 07:37:55 UTC Comment hidden (obsolete)
Comment 6 Arslan Farooq 2016-04-18 07:44:44 UTC
These steps worked:

--------------
To test:
1) Go to Admin -> Circulation and fines rules
2) Fines rules
	a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected
2) Default checkout, hold and return policy
	a) Confirm that column heading is now Actions
	b) Confirm that actions Save and Unset show as font awesome buttons and work as expected
3) Checkout limit by patron category AND holds policy by item type
	a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button)
4) Confirm that none of the buttons wrap on a narrower browser
--------------

And QA tools passed:

--------------
Processing files after patches
|========================>| 1 / 1 (100.00%)

 OK	koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
   OK	  forbidden patterns
   SKIP	  spelling
   OK	  tt_valid
   OK	  valid_template
--------------
Comment 7 Arslan Farooq 2016-04-18 07:53:43 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-04-18 10:32:30 UTC
Created attachment 50320 [details] [review]
Bug 16267: Making circ and fines rules actions buttons

EDIT: Comment 3

To test:
1) Go to Admin -> Circulation and fines rules
2) Fines rules
	a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected
2) Default checkout, hold and return policy
	a) Confirm that column heading is now Actions
	b) Confirm that actions Save and Unset show as font awesome buttons and work as expected
3) Checkout limit by patron category AND holds policy by item type
	a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button)
4) Confirm that none of the buttons wrap on a narrower browser

Sponsored-by: Catalyst IT

Signed-off-by: Arslan Farooq <arslanone@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Kyle M Hall 2016-04-29 10:54:56 UTC
Pushed to master, should be in the May 2016 release! Tak Aleisha!