Bug 16270 - Typo authentification vs authentication in 404
Summary: Typo authentification vs authentication in 404
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 14574
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-15 07:04 UTC by Jonathan Druart
Modified: 2016-12-05 21:25 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16270: Typo authentification/authentication (1.30 KB, patch)
2016-04-15 07:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16270: Typo authentification/authentication (1.40 KB, patch)
2016-04-15 13:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16270 (followup) Typo authentification vs authentication (2.42 KB, patch)
2016-04-15 14:23 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16270 (followup) Typo authentification vs authentication (2.47 KB, patch)
2016-04-19 03:08 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 16270: Typo authentification/authentication (1.41 KB, patch)
2016-04-19 03:09 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 16270 (followup) Typo authentification vs authentication (2.47 KB, patch)
2016-04-19 03:09 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 16270: Typo authentification/authentication (1.47 KB, patch)
2016-04-19 06:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 16270 (followup) Typo authentification vs authentication (2.54 KB, patch)
2016-04-19 06:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-04-15 07:04:22 UTC
See bug 14574 comment 5
Comment 1 Jonathan Druart 2016-04-15 07:06:58 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-15 12:15:04 UTC
There seem to be more occurences of authentification instead of authentication:

Visible in user interface:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

Other places:

C4/Auth.pm
C4/Auth_with_ldap.pm
C4/InstallAuth.pm
Comment 3 Owen Leonard 2016-04-15 13:09:02 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-04-15 14:23:26 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2016-04-15 14:24:09 UTC
Switching back to NSO for the followup.
Comment 6 Chris Cormack 2016-04-19 03:08:28 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2016-04-19 03:09:01 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2016-04-19 03:09:31 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2016-04-19 06:02:19 UTC
Created attachment 50381 [details] [review]
[PASSED QA] Bug 16270: Typo authentification/authentication

Test plan;
Trigger /cgi-bin/koha/errors/404.pl
Confirm the typo without the patch and that it's fixed with this patch
applied.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2016-04-19 06:02:22 UTC
Created attachment 50382 [details] [review]
[PASSED QA] Bug 16270 (followup) Typo authentification vs authentication

Additionally fix typo in following files:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt

To test: Apply patch, verify in files that authentification is
         replaced by authentication

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Kyle M Hall 2016-04-29 14:45:30 UTC
Pushed to master for the 16.05 release! Thanks Jonathan.

As an aside, I really want authentification to be a word ; )
Comment 12 Jonathan Druart 2016-04-29 14:57:26 UTC
(In reply to Kyle M Hall from comment #11)
> Pushed to master for the 16.05 release! Thanks Jonathan.
> 
> As an aside, I really want authentification to be a word ; )

Learn French and it will! :)
Comment 13 Julian Maurice 2016-05-16 12:08:48 UTC
Patch pushed to 3.22.x, will be in 3.22.7