Some of our patrons are not sure they succeed their self registration and self register multiple times. We would like to prevent this by blocking the selfregistration if the field borrowers.email is already filled by the same email address.
Created attachment 50612 [details] [review] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 50613 [details] [review] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 51064 [details] [review] [SIGNED-OFF] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors
Created attachment 51065 [details] [review] [SIGNED-OFF] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors.
Created attachment 51181 [details] [review] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 51182 [details] [review] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
In general this seems to work nicely without enforcing email verification (PatronSelfRegistrationVerifyByEmail). I ran into problems testing with email verification, because of bug 16985. It seems you can register as many patrons as you want with the same e-mail as long as they are not confirmed. I wanted to test to the second patron to use the confirmation link, but can't right now. Jonathan, can you describe what should happen?
(In reply to Katrin Fischer from comment #7) > It seems you can register as many patrons as you want with the same e-mail > as long as they are not confirmed. I wanted to test to the second patron to > use the confirmation link, but can't right now. Jonathan, can you describe > what should happen? Yes, it is the expected behavior. The test is only done on registered patrons.
Created attachment 53862 [details] [review] [PASSED QA] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 53863 [details] [review] [PASSED QA] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I am grateful that this is a preference and not a behavior change. We have many family members that use the same e-mail address for more than one account, and this would make it impossible for them to register more than one family member.
It's totally optional - I tested with the option being off as well.
Pushed to master for 16.11, thanks Jonathan!