Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form
Summary: write_age() function throws error for patron categories that don't include da...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 15206
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-18 16:07 UTC by Nick Clemens
Modified: 2016-12-05 21:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form (1.15 KB, patch)
2016-04-18 17:18 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form (1.30 KB, patch)
2016-04-19 01:46 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form (1.37 KB, patch)
2016-04-19 06:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-04-18 16:07:12 UTC
To confirm:

Add a new patron fo type Library or School
Check js console and see "TypeError: document.form.dateofbirth is undefined"
Comment 1 Nick Clemens 2016-04-18 17:18:26 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-04-19 01:46:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-19 06:21:10 UTC
Created attachment 50385 [details] [review]
[PASSED QA] Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form

To test:
1 Add a patron in category Library or School
2 Note the js error in the console
3 Apply patch
4 Repeat and note the error is gone

Signed-off-by: Chris Cormack <chrisc@catalyst.net.z>

Made it an explicit if, and fixed the author of the commit

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-04-20 18:37:39 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-21 08:24:03 UTC
Not needed in stable versions, status changed to RESOLVED