There is one use of "onclick" in admin/audio_alerts.tt. It should be rewritten so that JS functionality can be separate from the markup.
Created attachment 50462 [details] [review] Bug 16310 - Remove the use of "onclick" from audio alerts template This patch removes one use of "onclick" in favor of defining events in the JavaScript. This patch also makes changes to the style of some buttons to make the interface a little more consistent with current practices. To test, apply the patch and go to Administration -> Audio alerts. - In the list of existing audio alerts, click the "Edit" button for any alert. The correct data should be loaded in the edit form.
Created attachment 50464 [details] [review] Bug 16310 - Remove the use of "onclick" from audio alerts template This patch removes one use of "onclick" in favor of defining events in the JavaScript. This patch also makes changes to the style of some buttons to make the interface a little more consistent with current practices. To test, apply the patch and go to Administration -> Audio alerts. - In the list of existing audio alerts, click the "Edit" button for any alert. The correct data should be loaded in the edit form. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 50627 [details] [review] [PASSED QA] Bug 16310 - Remove the use of "onclick" from audio alerts template This patch removes one use of "onclick" in favor of defining events in the JavaScript. This patch also makes changes to the style of some buttons to make the interface a little more consistent with current practices. To test, apply the patch and go to Administration -> Audio alerts. - In the list of existing audio alerts, click the "Edit" button for any alert. The correct data should be loaded in the edit form. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for the 16.05 release. Thanks Owen!
Pushed in 16.05. Will be in 16.05.03.