I have a customer that wants to be able to limit a patron search to just searching for surnames.
Created attachment 50504 [details] [review] Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe" - Set "Search fields" = Surname and search for "doe". Neither "Doe John" nor "John Doe" should show up. Sponsored-by: Alingsås Public Library, Sweden
> - Set "Search fields" = Surname and search for "doe". > Neither "Doe John" nor "John Doe" should show up. Is this part of the test plan correct? Why should neither show up?
Created attachment 50536 [details] [review] Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden
Created attachment 50537 [details] [review] [SIGNED-OFF] Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Magnus, please provide test coverage for the change in C4::Utils::DataTables::Members::search. It would be quite easy to do, this subroutine is already well covered.
Created attachment 50712 [details] [review] Bug 16316 - QA FOLLOWUP - Add tests Add 6 tests for searching by surname. To test, run: prove t/db_dependent/Utils/Datatables_Members.t
Created attachment 50746 [details] [review] Bug 16316 - Limit patron search to surname This patch makes it possible to limit a patron search to search just for surnames. To test: - Apply the patch - Add two patrons, called e.g. "John Doe" and "Doe John" - Go to Patrons in the Intranet - Make sure you have selected "Search fields" = Standard - Search for "john" and verify both patrons show up - Search for "doe" and verify both patrons show up - Set "Search fields" = Surname and search for "john". "Doe John" should show up, but not "John Doe". - Set "Search fields" = Surname and search for "doe". "John Doe" should show up, but not "Doe John". Update: Revised the last point in the test plan. Sponsored-by: Alingsås Public Library, Sweden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 50747 [details] [review] Bug 16316 - QA FOLLOWUP - Add tests Add 6 tests for searching by surname. To test, run: prove t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for the Koha 16.05 release. Thanks Magnus!