Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable
Summary: Translatability: "Unknown" in suggestion/suggestion.pl not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 18:06 UTC by Marc Véron
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable (1.95 KB, patch)
2016-04-21 19:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16322 Translatability: "Unknown" in suggestion/suggestion.pl not translatable (2.02 KB, patch)
2016-04-21 21:39 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16322: Translatability: Also adding "Status unknown" to column table (1.25 KB, patch)
2016-04-21 21:45 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16322: Translatability: Also adding "Status unknown" to column table (1.38 KB, patch)
2016-04-22 06:27 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable (2.12 KB, patch)
2016-04-22 10:00 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16322: Translatability: Also adding "Status unknown" to column table (1.38 KB, patch)
2016-04-22 10:01 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-04-21 18:06:34 UTC
See suggestion/suggestion.pl line 59:
return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown";
Comment 1 Marc Véron 2016-04-21 19:29:31 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-21 21:39:06 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-04-21 21:45:49 UTC Comment hidden (obsolete)
Comment 4 Héctor Eduardo Castro Avalos 2016-04-21 21:47:12 UTC
Hi Marc

I changed the status unknown in the column table too.

Feel free to obsolete the last patch if you don't like the idea. No Biggie.
Comment 5 Marc Véron 2016-04-22 06:22:02 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #4)
> Hi Marc
> 
> I changed the status unknown in the column table too.
> 
> Feel free to obsolete the last patch if you don't like the idea. No Biggie.

Hi Héctor, thanks for catching. I will sign off on your patch.
Comment 6 Marc Véron 2016-04-22 06:27:11 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-04-22 06:48:21 UTC
(In reply to Marc Véron from comment #1)
(...)
> Note: If you have a suggestion with unknown status, all suggestions are
> listed under this tab. This is not in the scope of this bug; this bug is
> about translation only.
(...)
See Bug 16325
Comment 8 Marcel de Rooy 2016-04-22 10:00:22 UTC
Created attachment 50575 [details] [review]
Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable

This patch adds translatability for the tab "Unknown" in
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt

To test:
- Apply patch
- Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
  and verify that it handles the label "Unknown" (line 496)
- Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status --
  and verify that the tab "Status unknown" appears
- Bonus test: Go through a translation process and verify that "Status unknown" is
  translated

Note: If you have a suggestion with unknown status, all suggestions are listed under
      this tab. This is not in the scope of this bug; this bug is about translation
      only.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as expected

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2016-04-22 10:01:00 UTC
Created attachment 50576 [details] [review]
Bug 16322: Translatability: Also adding "Status unknown" to column table

Also add the "Status unknown to the column table
To test: follow previous commit

Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Kyle M Hall 2016-04-29 16:02:23 UTC
Pushed to master for the 16.05 release. Thanks Marc!
Comment 11 Julian Maurice 2016-05-16 11:22:36 UTC
Patch pushed to 3.22.x, will be in 3.22.7