When Bug 15793 removed the radio buttons I think the datatables sort parameters were not updated, you can now not sort based on patrons name To recreate: 1 - Have borrowers in your system 2 - Do a 'Check out' search to return several 3 - Note you cannot sort by name column
Created attachment 50634 [details] [review] Bug 16334 - Cannot sort checkout search by name This patch corrects the DataTable configuration of the table of patrons which displays when you search by patron name in circulation. To test, apply the patch and perform a search by patron name in circulation which will return multiple results. In the table of search results the "Name" column should be sortable, and sorted by default. Also changed: "Cardnumber" table header changed to "Card number."
Created attachment 50635 [details] [review] Bug 16334 - Cannot sort checkout search by name This patch corrects the DataTable configuration of the table of patrons which displays when you search by patron name in circulation. To test, apply the patch and perform a search by patron name in circulation which will return multiple results. In the table of search results the "Name" column should be sortable, and sorted by default. Also changed: "Cardnumber" table header changed to "Card number." Signed-off-by: Marc Véron <veron@veron.ch>
(In reply to Owen Leonard from comment #1) > In the table of search results the "Name" column should be sortable, and > sorted by default. In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch.
(In reply to Jonathan Druart from comment #3) > (In reply to Owen Leonard from comment #1) > > In the table of search results the "Name" column should be sortable, and > > sorted by default. > > In 3.20.x and 3.22.x the table is sorted by card number. > I am not sure we should change this behavior in this patch. In 3.18, before the datatables here, the default was surname, I think the use of cardnumber was a change introduced when the search was changed and this reverts it to previous standard
(In reply to Nick Clemens from comment #4) > (In reply to Jonathan Druart from comment #3) > > (In reply to Owen Leonard from comment #1) > > > In the table of search results the "Name" column should be sortable, and > > > sorted by default. > > > > In 3.20.x and 3.22.x the table is sorted by card number. > > I am not sure we should change this behavior in this patch. > > In 3.18, before the datatables here, the default was surname, I think the > use of cardnumber was a change introduced when the search was changed and > this reverts it to previous standard I am ok to change the behavior but on its own bug report, to get more opinions and highlight the change.
(In reply to Jonathan Druart from comment #3) > In 3.20.x and 3.22.x the table is sorted by card number. > I am not sure we should change this behavior in this patch. Jonathan, in Bug 13926 (now in master) you changed the default sort to be on patron category. Was that intentional?
(In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #3) > > > In 3.20.x and 3.22.x the table is sorted by card number. > > I am not sure we should change this behavior in this patch. > > Jonathan, in Bug 13926 (now in master) you changed the default sort to be on > patron category. Was that intentional? I dont' think so
Instead of resubmitting this patch, I'm incorporating a corrected fix into Bug 16336, "UX of holds patron search with long lists of results."