Bug 16368 - Remove obsolete attributes from table tags
Summary: Remove obsolete attributes from table tags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 14:26 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16368 - Remove obsolete attributes from table tags (2.97 KB, patch)
2016-04-27 14:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16368 - Remove obsolete attributes from table tags (3.06 KB, patch)
2016-04-27 14:51 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16368 - Remove obsolete attributes from table tags (3.13 KB, patch)
2016-04-27 16:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-27 14:26:18 UTC
There are a few instances in the staff client templates where obsolete attributes are included in <table> markup: border, cellpadding, cellspacing. These should be removed.
Comment 1 Owen Leonard 2016-04-27 14:37:35 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-27 14:51:47 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-27 16:25:22 UTC
Created attachment 50830 [details] [review]
[PASSED QA] Bug 16368 - Remove obsolete attributes from table tags

This patch removes some obsolete attributes from table markup: border,
cellpadding, and cellspacing. These changes should have no visible
effect.

- To test the changes to the reports dictionary, go to Reports -> View
  dictionary. The table of dictionary definitions should look correct.

- To test the changes to MARC plugins, you must be using MARC21. Open a
  new or existing MARC record in the standard cataloging editor and
  trigger the tag editor for 006 and 008. The tables in each popup
  window should look correct.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-04-29 16:13:33 UTC
Pushed to master for the 16.05 release. Thanks Owen!