Bug 16373 - merge.pl reports success but files are not merged
Summary: merge.pl reports success but files are not merged
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P3 blocker
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 22:54 UTC by Nick Clemens (kidclamp)
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16373: merge.pl reports success but files are not merged (1.53 KB, patch)
2016-04-28 07:51 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
Bug 16373: merge.pl reports success but files are not merged (1.58 KB, patch)
2016-04-28 08:59 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 16373: merge.pl reports success but files are not merged (1.65 KB, patch)
2016-04-28 09:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2016-04-27 22:54:01 UTC
Testing on master and 3.22.5 showed this issue, 3.20.x everything works fine

To recreate:
Select two biblios to merge
Merge them
Sucess reported but list of bibs contains only the reference record. 
View the 'new' record, it won't have any additional items
View the 'merged' record, it is still there with its items
Comment 1 Katrin Fischer 2016-04-27 22:57:59 UTC
Can confirm this is broken again on master.
Comment 2 Jacek Ablewicz 2016-04-28 07:51:16 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2016-04-28 08:59:25 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-04-28 09:36:47 UTC
Looking at this!
Comment 5 Katrin Fischer 2016-04-28 09:44:42 UTC
Created attachment 50886 [details] [review]
[PASSED QA] Bug 16373: merge.pl reports success but files are not merged

To recreate:

1) Select two biblios to merge
2) Merge them
3) Sucess reported but list of bibs contains only the reference record.
4) View the 'new' record, it won't have any additional items
5) View the 'merged' record, it is still there with its items

This happens because record IDs (biblionumbers) are not correctly
set up in the template on the 2nd merge stage, since Bug 15358.

To test:

1) apply patch
2) try to recreate this issue once again, confirm that a problem
is resolved

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2016-04-28 09:45:12 UTC
Hi Jacek, thx a lot for the quick fix!
Comment 7 Brendan Gallagher 2016-04-28 23:25:07 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 8 Julian Maurice 2016-05-09 08:07:22 UTC
Patch pushed to 3.22.x, will be in 3.22.7