Bug 16381 - Fix capitalization on tags review page
Summary: Fix capitalization on tags review page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16394
  Show dependency treegraph
 
Reported: 2016-04-29 00:15 UTC by Katrin Fischer
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16381: Fix capitalization on tags review page (1.99 KB, patch)
2016-04-29 00:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 16381: Fix capitalization on tags review page (2.29 KB, patch)
2016-04-29 09:13 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16381: Fix capitalization on tags review page (2.36 KB, patch)
2016-04-29 14:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16381 [QA Followup] - Wrap string for translations (1.03 KB, patch)
2016-04-29 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-04-29 00:15:01 UTC

    
Comment 1 Katrin Fischer 2016-04-29 00:18:39 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-29 09:13:02 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-04-29 09:18:10 UTC
Regarding tab chars see: Bug 16394 - Fix formatting of review.tt
Comment 4 Jonathan Druart 2016-04-29 14:24:21 UTC
Created attachment 50998 [details] [review]
Bug 16381: Fix capitalization on tags review page

- Fixes capitalization of the sub heading "Displaying ... terms"
- Fixes button label of "Test"

To test:
- Look at all, approved, rejected, pending tags and check
  the line below the heading "Tags" - "Displaying..."
- Check a term using the search box on the left side
  Before the patch: Test - Processing... - test
  After the patch this should be Test again in the end.

Capitalization looks good. QA tools complain about tabs, but there
are loads of tabs all over review.tt. Proper formatting of the whole file
could be done in a separate bug.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Kyle M Hall 2016-04-29 16:09:40 UTC
Created attachment 51022 [details] [review]
Bug 16381 [QA Followup] - Wrap string for translations

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2016-04-29 16:10:53 UTC
Pushed to master for Koha 16.05. Thanks Katrin!
Comment 7 Julian Maurice 2016-05-16 12:17:26 UTC
Patch pushed to 3.22.x, will be in 3.22.7