Created attachment 50977 [details] [review] Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT
Created attachment 50990 [details] [review] Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch>
Aleisha, should not we have a group of buttons under the 'Download' button with the 3 choices instead?
Created attachment 51450 [details] [review] Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar as a dropdown with the 3 options (csv, tab and ods) 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT
Created attachment 51456 [details] [review] [SIGNED-OFF] Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar as a dropdown with the 3 options (csv, tab and ods) 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 51473 [details] [review] Bug 16388: Move option to download report into reports toolbar To test: 1) Create a new SQL report or edit a report 2) Ensure that the download option does NOT show in the toolbar 3) Save and run the report 4) Confirm that download option DOES show in toolbar as a dropdown with the 3 options (csv, tab and ods) 5) Confirm that downloading all 3 file types works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51474 [details] [review] Bug 16388: Use existing 'execute' parameter instead of creating a new one An existing 'execute' parameter is already passed to the template when we need to display the 'Download' button, so let's use it instead of creating a new one. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the November 2016 Release. Thanks
Pushed in 16.05. Will be in 16.05.01.