Bug 16389 - Reports row limit should change upon option selection
Summary: Reports row limit should change upon option selection
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 03:00 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16389: Reports row limit should change upon option selection (2.26 KB, patch)
2016-04-29 03:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16389: Reports row limit should change upon option selection (2.35 KB, patch)
2016-04-29 13:18 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16389: Reports row limit should change upon option selection (2.42 KB, patch)
2016-04-29 16:06 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-29 03:00:32 UTC

    
Comment 1 Aleisha Amohia 2016-04-29 03:02:21 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-29 13:18:24 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-29 15:43:47 UTC
Aleisha,
The patch works as advertise, but I would prefer to see more descriptive/useful name for the ids.
For instance, the id on the select is not needed.
I'd say we could change the jQuery selector instead to $('select.limit').
On the same way, we could search for the form using the parents() selector, but I think it's better to select the form by id. But 'limitselect' is not a correct description for the form element.
Comment 4 Jonathan Druart 2016-04-29 16:06:12 UTC
Created attachment 51021 [details] [review]
Bug 16389: Reports row limit should change upon option selection

To test:
1) Run a report
2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown
3) Change the limit (i.e. to 10)
4) Confirm the page updates itself

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2016-04-29 16:06:35 UTC
After a chat with Owen, your patch looks good.
Comment 6 Kyle M Hall 2016-04-29 16:51:35 UTC
Pushed to master for the 16.05 release! Thanks Aleisha!