Bug 16405 - Fix Circulation/NoIssuesChargeGuarantees.t test 2
Summary: Fix Circulation/NoIssuesChargeGuarantees.t test 2
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Galen Charlton
URL:
Keywords:
Depends on: 14577
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-30 13:02 UTC by Marcel de Rooy
Modified: 2016-12-05 21:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 (1.40 KB, patch)
2016-04-30 13:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 (1.45 KB, patch)
2016-04-30 16:02 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 (1.37 KB, patch)
2016-05-02 09:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 (1.47 KB, patch)
2016-05-02 10:11 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 (1.48 KB, patch)
2016-05-02 19:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-04-30 13:02:27 UTC
Resolve:
#   Failed test 'Patron cannot check out item due to debt for guarantee'
#   at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
#          got: '10'
#     expected: '10.00'
Comment 1 Marcel de Rooy 2016-04-30 13:04:02 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2016-04-30 16:02:42 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-05-02 07:01:34 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Thx for your signoffs, Bernardo.
Comment 4 Jonathan Druart 2016-05-02 09:41:20 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-05-02 09:41:57 UTC
Marcel, I think it's better to keep `is`, could you have a look at my alternative patch please?
Comment 6 Marcel de Rooy 2016-05-02 10:11:13 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2016-05-02 10:14:24 UTC
No problem.

is( $issuingimpossible->{DEBT_GUARANTEES} == 10.00 , 1, '')
and 
is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, '')

look the same to me btw
Comment 8 Tomás Cohen Arazi 2016-05-02 19:18:10 UTC
Created attachment 51113 [details] [review]
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2

Resolves:
Failed test 'Patron cannot check out item due to debt for guarantee'
at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
          got: '10'
     expected: '10.00'

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Kyle M Hall 2016-05-04 14:24:10 UTC
Pushed to master for Koha 16.05, thanks Jonathan!
Comment 10 Julian Maurice 2016-05-16 08:59:33 UTC
Not needed in stable versions, status changed to RESOLVED