Bug 16411 - Make Hold.t not depend on two existing branches
Summary: Make Hold.t not depend on two existing branches
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-02 08:11 UTC by Marcel de Rooy
Modified: 2016-12-05 21:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16411: Make Hold.t not depend on two existing branches (3.24 KB, patch)
2016-05-02 08:13 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16411: Make Hold.t not depend on two existing branches (3.33 KB, patch)
2016-05-02 12:08 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16411: Make Hold.t not depend on two existing branches (3.38 KB, patch)
2016-05-04 14:53 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-05-02 08:11:34 UTC
If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value at t/db_dependent/Hold.t line 60.
Comment 1 Marcel de Rooy 2016-05-02 08:13:29 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-02 12:08:35 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2016-05-04 14:53:23 UTC
Created attachment 51192 [details] [review]
Bug 16411: Make Hold.t not depend on two existing branches

If you do not have two branches, this test will fail.
Can't call method "branchcode" on an undefined value.

This patch adds a borrower and two branches with TestBuilder.

Test plan:
Run the test.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Brendan Gallagher 2016-05-05 18:27:45 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!