Bug 16415 - Layout problem on staff client detail page if local cover images are enabled
Summary: Layout problem on staff client detail page if local cover images are enabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/catalogue/detail.pl?bib...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-02 14:07 UTC by Owen Leonard
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Screenshot showing layout problem (93.02 KB, image/png)
2016-05-02 14:07 UTC, Owen Leonard
Details
Bug 16415 - Layout problem on staff client detail page if local cover images are enabled (1.67 KB, patch)
2016-05-02 14:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16415 - Layout problem on staff client detail page if local cover images are enabled (1.79 KB, patch)
2016-05-02 15:09 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16415 - Layout problem on staff client detail page if local cover images are enabled (1.85 KB, patch)
2016-05-04 16:42 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-05-02 14:07:48 UTC
Created attachment 51102 [details]
Screenshot showing layout problem

If you have local cover images enabled in the staff client but not Amazon images, local covers are not displayed in a column on the right like they should be.
Comment 1 Owen Leonard 2016-05-02 14:16:18 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-02 15:09:32 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-05-04 16:42:37 UTC
Created attachment 51209 [details] [review]
Bug 16415 - Layout problem on staff client detail page if local cover images are enabled

This patch fixes a layout problem which appears on the staff client
bibliographic detail page if local covers are enabled but Amazon covers
are not.

To test, apply the patch and turn off AmazonCoverImages.

- Enable the LocalCoverImages system preference and locate or create a
  record which has a local cover image associated with it.
- View the bibliographic detail page. The bibliographic details should
  display in two columns, with text on the left and local cover image on
  the right.
- Test with AmazonCoverImages and LocalCoverImages enabled.
- Test with AmazonCoverImages enabled and LocalCoverImages disabled.

All combinations are OK.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-05-05 18:31:06 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-05-16 11:33:14 UTC
Patch pushed to 3.22.x, will be in 3.22.7