Bug 16419 - Tests of t/db_dependent/Acquisition.t do not pass
Summary: Tests of t/db_dependent/Acquisition.t do not pass
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 11371
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-02 14:40 UTC by Jonathan Druart
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t (1.57 KB, patch)
2016-05-02 14:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t (1.70 KB, patch)
2016-05-02 14:51 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t (1.83 KB, patch)
2016-05-02 15:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-05-02 14:40:57 UTC
The tests added by bug 11371 have been put after the rollback statement.
Comment 1 Jonathan Druart 2016-05-02 14:41:37 UTC
% prove t/db_dependent/Acquisition.t
t/db_dependent/Acquisition.t .. 63/91 
#   Failed test 'GetBudgetReport OK'
#   at t/db_dependent/Acquisition.t line 950.

#   Failed test 'GetBudgetsReport(1) OK'
#   at t/db_dependent/Acquisition.t line 953.
# Looks like you failed 2 tests of 91.
Comment 2 Jonathan Druart 2016-05-02 14:42:51 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-05-02 14:51:53 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi 2016-05-02 15:10:28 UTC
Created attachment 51110 [details] [review]
Bug 16419: follow-up of bug 11371 - Fix t/db_dependent/Acquisition.t

The tests added by bug 11371 have been put after the rollback statement.

Test plan:
  prove t/db_dependent/Acquisition.t
should return green

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tests fail before the patch, and pass with it. QA scripts like the patch too.
Comment 5 Kyle M Hall 2016-05-03 15:31:50 UTC
Pushed to master for 16.05, thanks Jonathan!
Comment 6 Julian Maurice 2016-05-16 09:15:16 UTC
Not needed in stable versions, status changed to RESOLVED