"Hold found": "Confirm hold", "Print slip and confirm" and "Ignore" "Hold found (item is already waiting)": "Confirm", "Cancel hold", "Print and confirm" We should settle on one ordering and wording; the current approach is both bad for translators and confusing for librarians. It's all too easy to reach for the middle button out of muscle memory and cancel a hold! I would argue that the wording and ordering of the "Hold found" dialog is more natural, so the waiting dialog should be changed to the following: "Confirm hold", "Print slip and confirm", "Cancel hold"
Created attachment 80144 [details] [review] Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold."
Created attachment 80145 [details] [review] Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 80242 [details] [review] Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.12