This page seems very confusing. There is no 'new' button, just edit and conditions and substitutions are confusing in terms of language. I think this page could do with the Owen magic touch :)
Created attachment 51232 [details] [review] Bug 16437 - Automatic item modifications by age needs prettying This patch makes layout and behavior changes to the automatic item modifications by age interface, bringing some aspects of it closer into conformance with established interface patterns. - The intial view is now a standard table of information about existing rules, or a message dialog saying there are no rules. - If there are no rules, a toolbar button reads "Add rules." - If there are existing rules, the toolbar button reads "Edit rules." - Clicking the button leads to the rules edit interface, which now has a floating toolbar with "Add rule," "Save," and "Cancel" buttons. - Clicking the "Add rule" button displays a blank rule block. - If you are adding a rule to existing rules, the new block is appended at the bottom, and the page scrolls to the new rule. - As you add or remove rule blocks, the legend containing the rule count updates so that the numbers are sequential. - In each rule block, "age" and "substitutions" are now required. The age field is now validated to require a number. - The add/remove condition/substitution links now have more descriptive text labels. - The control to remove a rule is now a link in the <legend> element associated with each rule. - Most JavaScript for this page is now in a separate file. - Breadcrumbs are updated to be a little more specific. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modifications by age. - Test adding and removing rules. - Test removing all rules. - Test adding and removing conditions and substitutions within rules. - Test submitting the form without filling in required fields.
Created attachment 51233 [details] [review] Bug 16437 - Automatic item modifications by age needs prettying This patch makes layout and behavior changes to the automatic item modifications by age interface, bringing some aspects of it closer into conformance with established interface patterns. - The intial view is now a standard table of information about existing rules, or a message dialog saying there are no rules. - If there are no rules, a toolbar button reads "Add rules." - If there are existing rules, the toolbar button reads "Edit rules." - Clicking the button leads to the rules edit interface, which now has a floating toolbar with "Add rule," "Save," and "Cancel" buttons. - Clicking the "Add rule" button displays a blank rule block. - If you are adding a rule to existing rules, the new block is appended at the bottom, and the page scrolls to the new rule. - As you add or remove rule blocks, the legend containing the rule count updates so that the numbers are sequential. - In each rule block, "age" and "substitutions" are now required. The age field is now validated to require a number. - The add/remove condition/substitution links now have more descriptive text labels. - The control to remove a rule is now a link in the <legend> element associated with each rule. - Most JavaScript for this page is now in a separate file. - Breadcrumbs are updated to be a little more specific. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modifications by age. - Test adding and removing rules. - Test removing all rules. - Test adding and removing conditions and substitutions within rules. - Test submitting the form without filling in required fields.
Created attachment 51243 [details] [review] Bug 16437 - Automatic item modifications by age needs prettying This patch makes layout and behavior changes to the automatic item modifications by age interface, bringing some aspects of it closer into conformance with established interface patterns. - The intial view is now a standard table of information about existing rules, or a message dialog saying there are no rules. - If there are no rules, a toolbar button reads "Add rules." - If there are existing rules, the toolbar button reads "Edit rules." - Clicking the button leads to the rules edit interface, which now has a floating toolbar with "Add rule," "Save," and "Cancel" buttons. - Clicking the "Add rule" button displays a blank rule block. - If you are adding a rule to existing rules, the new block is appended at the bottom, and the page scrolls to the new rule. - As you add or remove rule blocks, the legend containing the rule count updates so that the numbers are sequential. - In each rule block, "age" and "substitutions" are now required. The age field is now validated to require a number. - The add/remove condition/substitution links now have more descriptive text labels. - The control to remove a rule is now a link in the <legend> element associated with each rule. - Most JavaScript for this page is now in a separate file. - Breadcrumbs are updated to be a little more specific. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modifications by age. - Test adding and removing rules. - Test removing all rules. - Test adding and removing conditions and substitutions within rules. - Test submitting the form without filling in required fields. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
1/ The age field is not mandatory 2/ The right member of the substitutions is not mandatory (you could empty it)
3/ "Remove condition/substitution" moves the scrollbar to the top
(In reply to Jonathan Druart from comment #5) > 3/ "Remove condition/substitution" moves the scrollbar to the top Also "Remove this rule"
Jonathan could you check the issues you mention in comment 5 and comment 6 again? I cannot reproduce the problem. If they persist, are there JS errors?
(In reply to Owen Leonard from comment #7) > Jonathan could you check the issues you mention in comment 5 and comment 6 > again? I cannot reproduce the problem. If they persist, are there JS errors? Yes they persist and I do not get any JS errors.
Created attachment 51658 [details] [review] Bug 16437 - Automatic item modifications by age needs prettying This patch makes layout and behavior changes to the automatic item modifications by age interface, bringing some aspects of it closer into conformance with established interface patterns. - The intial view is now a standard table of information about existing rules, or a message dialog saying there are no rules. - If there are no rules, a toolbar button reads "Add rules." - If there are existing rules, the toolbar button reads "Edit rules." - Clicking the button leads to the rules edit interface, which now has a floating toolbar with "Add rule," "Save," and "Cancel" buttons. - Clicking the "Add rule" button displays a blank rule block. - If you are adding a rule to existing rules, the new block is appended at the bottom, and the page scrolls to the new rule. - As you add or remove rule blocks, the legend containing the rule count updates so that the numbers are sequential. - In each rule block, "age" and "substitutions" are now required. The age field is now validated to require a number. - The add/remove condition/substitution links now have more descriptive text labels. - The control to remove a rule is now a link in the <legend> element associated with each rule. - Most JavaScript for this page is now in a separate file. - Breadcrumbs are updated to be a little more specific. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modifications by age. - Test adding and removing rules. - Test removing all rules. - Test adding and removing conditions and substitutions within rules. - Test submitting the form without filling in required fields. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51659 [details] [review] Bug 16437 - (follow-up) Automatic item modifications by age needs prettying Do not move the scrollbar to the top when removing a 'block' to a new rule. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #8) > (In reply to Owen Leonard from comment #7) > > Jonathan could you check the issues you mention in comment 5 and comment 6 > > again? I cannot reproduce the problem. If they persist, are there JS errors? > > Yes they persist and I do not get any JS errors. Ok fixed!
Pushed to Master - Should be in the November 2016 Release. Thanks!
Pushed in 16.05. Will be in 16.05.01.
(In reply to Jonathan Druart from comment #4) > 1/ The age field is not mandatory > 2/ The right member of the substitutions is not mandatory (you could empty > it) I think that I have missed to check these 2 remarks before passing it. The age field is not mandatory (and should not) as well as the substitutions.
(In reply to Jonathan Druart from comment #14) > (In reply to Jonathan Druart from comment #4) > > 1/ The age field is not mandatory > > 2/ The right member of the substitutions is not mandatory (you could empty > > it) > > I think that I have missed to check these 2 remarks before passing it. > The age field is not mandatory (and should not) as well as the substitutions. See bug 18752.