Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion
Created attachment 51169 [details] [review] Bug 16438: Use Font Awesome icons in batch record deletion table Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion To test: 1- Go to Tools > Batch record deletion 2- Try to delete bib and authorities records 3- Look the table presented 4- Apply patch and repeat steps 1 to 3
Created attachment 51170 [details] [review] Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3
Created attachment 51171 [details] [review] [SIGNED-OFF] Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work, nice view. No Errors
I would prefer that we use no icon if there is no single icon which works well.
Created attachment 51210 [details] [review] Bug 16438: (followup) change icons to one icon Change the two icons to just one: "fa fa-minus-square" To test: follow the previous commit
Created attachment 51211 [details] [review] Bug 16438: (followup) change icons to one icon Change the two icons to just one: "fa fa-minus-square" To test: follow the previous commit
Hi Owen and Jonathan Please look if this is Ok Regards
My vote is still for no icon.
(In reply to Owen Leonard from comment #8) > My vote is still for no icon. For all options or just for those icons which don't work well?
Created attachment 51212 [details] [review] Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit
Hi Owen I've deleted the icons for options where icon doesn't fit well with description. Feel free to change and/or close the bug if you think this isn't the right way. No biggie. Regards
Created attachment 51213 [details] [review] [SIGNED-OFF] Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 51214 [details] [review] Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work, nice view. No Errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51215 [details] [review] Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - should be in the May 2016 Release. thanks!