Bug 16447 - "Borrow Permission" should not be used anymore
Summary: "Borrow Permission" should not be used anymore
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 7976
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-05 13:51 UTC by Jonathan Druart
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16447: Remove occurrence of the borrow permission which does no longer exist (3.02 KB, patch)
2016-05-05 13:58 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 16447: Remove occurrence of the borrow permission which does no longer exist (4.13 KB, patch)
2016-05-05 15:16 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 16447: Remove occurrence of the borrow permission which does no longer exist (4.29 KB, patch)
2016-05-05 19:16 UTC, Marc Véron 		Details | Diff | Splinter Review
[PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist (4.33 KB, patch)
2016-05-05 21:06 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-05-05 13:51:03 UTC 
Bug 7976 has removed this permission, but other patches re-added it...
Comment 1 Jonathan Druart 2016-05-05 13:58:35 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-05 14:43:24 UTC 
(In reply to Jonathan Druart from comment #1)
(...)
> Note that the occurrences in sendbasket.pl and opac/svc/login should
> have been removed by bug 16447.
We are on Bug 16447 - mistake of bug number?

> Test plan:
>   git grep 'borrow => 1'
> should not return any results.

Is OK, but git grep 'borrow ' finds additonally:

edithelp.pl:            borrow           => 1,
t/db_dependent/Auth.t:            borrow            => 0
Comment 3 Jonathan Druart 2016-05-05 15:16:49 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-05-05 15:19:52 UTC 
(In reply to Marc Véron from comment #2)
> (In reply to Jonathan Druart from comment #1)
> (...)
> > Note that the occurrences in sendbasket.pl and opac/svc/login should
> > have been removed by bug 16447.
> We are on Bug 16447 - mistake of bug number?
> 
> > Test plan:
> >   git grep 'borrow => 1'
> > should not return any results.
> 
> Is OK, but git grep 'borrow ' finds additonally:
> 
> edithelp.pl:            borrow           => 1,
> t/db_dependent/Auth.t:            borrow            => 0

Good catches, fixed!
Comment 5 Marc Véron 2016-05-05 19:16:55 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-05-05 21:06:01 UTC 
Created attachment 51262 [details] [review]
[PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist

Bug 7976 has removed this permission, but other patches re-added it...
Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should
have been removed by bug 7976.

Test plan:
  git grep 'borrow.*=> 1'
should not return any results.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Brendan Gallagher 2016-05-05 21:28:45 UTC 
Pushed to master - Should be in the May 2016 release.  Thanks!
Comment 8 Julian Maurice 2016-05-16 09:37:19 UTC 
Patch pushed to 3.22.x, will be in 3.22.7