When adding a guantor to a patron record, a search form is shown in a popup window. This page should be reworked to avoid the use of "onclick."
Created attachment 51241 [details] [review] Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section.
Created attachment 51252 [details] [review] Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section. Tested on top of Bug 13041 and Bug 16386, works as expected, however see Bug 16458 Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 51293 [details] [review] Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section. Tested on top of Bug 13041 and Bug 16386, works as expected, however see Bug 16458 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
*** Bug 14744 has been marked as a duplicate of this bug. ***
Pushed to Master - Should be in the November 2016 Release. Thanks!
Pushed in 16.05. Will be in 16.05.01.
I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic that it depends on Bug 16386?
*** Bug 16756 has been marked as a duplicate of this bug. ***
Would like to see this and 16386 in 3.22.x.
(In reply to Owen Leonard from comment #7) > I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic > that it depends on Bug 16386? This patch seems not to be really dependent on bug 16386 (except that it was written on top of it). I'll try to write a patch for 3.22.x
(In reply to Julian Maurice from comment #10) > (In reply to Owen Leonard from comment #7) > > I think this patch will fix Bug 16756 (a 3.22.x bug), but is it problematic > > that it depends on Bug 16386? > > This patch seems not to be really dependent on bug 16386 (except that it was > written on top of it). > I'll try to write a patch for 3.22.x That is awesome. Thank you. :)
Created attachment 54538 [details] [review] [3.22.x] Bug 16450 - Remove the use of "onclick" from guarantor search template This patch updates the guarantor search template so that event definition is done in the script rather than in an onclick attribute. This patch also increases the size of the popup window to help prevent the need for horizontal scrolling and adds Bootstrap style to the "select" button. To test, apply the patch and clear your browser cache if necessary. - Go to Patrons and add a patron with a "child" category type. - In the "Guarantor information" section, click the "Set to patron" button. - In the pop-up window, search for a patron. - Click the "Select" button next to a patron. - The window should close, and the patron you selected should now appear as the guarantor. The guarantor's address information should be added to the "Main address" section. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Patch pushed to 3.22.x, will be in 3.22.10