Bug 16451 - Fix missing body id in orders_by_budget.tt
Summary: Fix missing body id in orders_by_budget.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 11371
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-05 14:27 UTC by Tomás Cohen Arazi
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16451: Fix missisng body id in orders_by_budget.tt (1.18 KB, patch)
2016-05-05 14:31 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16451: Fix missisng body id in orders_by_budget.tt (1.29 KB, patch)
2016-05-05 14:47 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 16451: Fix missisng body id in orders_by_budget.tt (1.30 KB, patch)
2016-05-05 22:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2016-05-05 14:27:58 UTC
To reproduce:

- Run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt
Comment 1 Tomás Cohen Arazi 2016-05-05 14:31:14 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-05-05 14:47:14 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-05-05 22:10:48 UTC
Created attachment 51267 [details] [review]
[PASSED QA] Bug 16451: Fix missisng body id in orders_by_budget.tt

Bug 11371 introduced a new template, which fails the xt/tt_valid.t tests.

To test:
- On master, run:
  $ prove xt/tt_valid.t
=> FAIL: Tests fail on orders_by_budget.tt
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests don't fail on orders_by_budget.tt
- Sign off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-05-06 03:48:35 UTC
Pushed To Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-05-16 09:38:46 UTC
Not needed in stable versions, status changed to RESOLVED