We don't say "check out/issue" or "patron/member," so I don't think we should use "inventory/stocktaking." Let's just say "inventory."
Created attachment 51452 [details] [review] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking' To test: 1) Go to the tools home page. Confirm it says 'Inventory' instead of 'Inventory/stocktaking' 2) Click Inventory. Confirm heading now says 'Inventory' instead of 'Inventory/stocktaking' 3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in the tools menu along the left of the page 4) Click Help in top right corner. Confirm help heading now says 'Inventory' instead of 'Inventory/stocktaking' Sponsored-by: Catalyst IT
This looks great, but it occurred to me to look for other forms of "stocktaking." I see some instances of "inventory (stocktaking)": /includes/permissions.inc: /modules/help/members/member-flags.tt: /modules/tools/tools-home.tt:
Created attachment 51459 [details] [review] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking' To test: 1) Go to the tools home page. Confirm it says 'Inventory' instead of 'Inventory/stocktaking' in heading and in description 2) Click Inventory. Confirm heading now says 'Inventory' instead of 'Inventory/stocktaking' 3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in the tools menu along the left of the page 4) Click Help in top right corner. Confirm help heading now says 'Inventory' instead of 'Inventory/stocktaking' 5) Go to user account page, go to Set Permissions 6) Expand Tools option and confirm it says 'inventory' instead of 'inventory (stocktaking)' Sponsored-by: Catalyst IT
Created attachment 51502 [details] [review] [SIGNED-OFF] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking' To test: 1) Go to the tools home page. Confirm it says 'Inventory' instead of 'Inventory/stocktaking' in heading and in description 2) Click Inventory. Confirm heading now says 'Inventory' instead of 'Inventory/stocktaking' 3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in the tools menu along the left of the page 4) Click Help in top right corner. Confirm help heading now says 'Inventory' instead of 'Inventory/stocktaking' 5) Go to user account page, go to Set Permissions 6) Expand Tools option and confirm it says 'inventory' instead of 'inventory (stocktaking)' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 51522 [details] [review] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking' To test: 1) Go to the tools home page. Confirm it says 'Inventory' instead of 'Inventory/stocktaking' in heading and in description 2) Click Inventory. Confirm heading now says 'Inventory' instead of 'Inventory/stocktaking' 3) Confirm that it now says 'Inventory' instead of 'Inventory/stocktaking' in the tools menu along the left of the page 4) Click Help in top right corner. Confirm help heading now says 'Inventory' instead of 'Inventory/stocktaking' 5) Go to user account page, go to Set Permissions 6) Expand Tools option and confirm it says 'inventory' instead of 'inventory (stocktaking)' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51523 [details] [review] Bug 16454: Remove another occurrence in comment Note that few other occurrences exist in DB. This patch also replaces a tab with 4 spaces. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.05, thanks Aleisha, Jonathan!
Patches pushed to 3.22.x, will be in 3.22.8