When adding patrons to a patron card batch using the search for patrons feature, the required permission is 'routing'... which makes no sense.
Created attachment 51295 [details] [review] Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card.
The patron card creator link on the tools home page uses: CAN_user_tools_label_creator I think that would make sense to me overall.
(In reply to Katrin Fischer from comment #2) > The patron card creator link on the tools home page uses: > CAN_user_tools_label_creator > I think that would make sense to me overall. Yes but it's the only script in this directory, others use catalogue. Moreover patroncards/edit-batch.pl, which calls add_user_search.pl, uses catalogue also, it would not make sense to have different perms. If we need to fix the whole module, it should be done on another bug report.
Ok - It sure doesn't make much sense now :) Having another bug report sounds good - maybe it would be best to add a new permission just for this tool.
Tested with patch: - Set permissions 'catalogue' and 'label_creator' - Go to Home > Tools > Patron card creator - New card batch - Add patrons - Search windows pops up. Do a search. Result: Endless "Processing" - Set addtitionally permission 'borrowers' Result: Search window works as expected, patrons are found and can be selected. I think there should be two separate permissions for '...creator', one for labels ('label_creator') and one for patron cards ('patroncard_creator'). The latter would then additionally need 'borrowers' (with a hint in the description)
Created attachment 51704 [details] [review] [SIGNED-OFF] Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 52814 [details] [review] Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patch pushed to 3.22.x, will be in 3.22.10