Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet (titles not showing in lists)
Summary: Virtualshelves: Using no XSLTResultsDisplay breaks content display in intrane...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-09 23:28 UTC by Nick Clemens
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet (1.28 KB, patch)
2016-05-10 00:36 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet (1.41 KB, patch)
2016-05-10 08:40 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet (1.42 KB, patch)
2016-05-20 06:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-05-09 23:28:11 UTC
Similar to bug 16296 but on the staff side
Comment 1 Nick Clemens 2016-05-10 00:36:03 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-10 08:40:17 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-05-11 10:51:12 UTC
opac-shelves.pl and virtualshelves/shelves.pl have diverged in this area.
The OPAC script calls GetBiblioData, which populated title and other infos.
It would make sense to add the call to the staff script to avoid different behaviors between these 2 scripts.

The eternal question is: should we continue to fix non-XSLT views? :)
Comment 4 Marcel de Rooy 2016-05-20 06:18:46 UTC
Created attachment 51634 [details] [review]
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet

To test:
1 - Create a list in staff client
2 - Set XSLTResultsDisplay to blank
3 - View list, titles don't display
4 - Apply patch
5 - View list, titles display
6 - Set XSLTResultsDisplay to default
7 - View list, titles display as before patch

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2016-05-20 06:22:01 UTC
(In reply to Jonathan Druart from comment #3)
> The eternal question is: should we continue to fix non-XSLT views? :)

If we deprecate something, we should make more definitive plans to remove the functionality too imo.
Since this is just a one-line fix restoring something very fundamental as the title of a book, I would recommend to push it.
Comment 6 Jonathan Druart 2016-05-20 08:42:58 UTC
Did you see my other concern about the divergence of the 2 files?
Comment 7 Marcel de Rooy 2016-05-20 08:46:35 UTC
(In reply to Jonathan Druart from comment #6)
> Did you see my other concern about the divergence of the 2 files?
Yes. These scripts should not contain so much logic.
Comment 8 Jonathan Druart 2016-05-20 08:50:49 UTC
(In reply to Jonathan Druart from comment #6)
> Did you see my other concern about the divergence of the 2 files?

I know it was not introduced by this patch, but it would be good to fix it (even on another bug report). But... it would be easiest to remove the code than to fix it...
Comment 9 Marcel de Rooy 2016-05-20 09:05:34 UTC
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #6)
> > Did you see my other concern about the divergence of the 2 files?
> 
> I know it was not introduced by this patch, but it would be good to fix it
> (even on another bug report). But... it would be easiest to remove the code
> than to fix it...

I would recommend now to build on top of this one liner (tested etc.)
New adjustments will not reach 16.05 anymore.
Comment 10 Kyle M Hall 2016-05-23 17:25:52 UTC
Pushed to master for 16.05, thanks Nick!
Comment 11 Julian Maurice 2016-05-25 09:20:46 UTC
Patch pushed to 3.22.x, will be in 3.22.7