Bug 16501 - Remove some unneeded warns in Upload.t
Summary: Remove some unneeded warns in Upload.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 14:19 UTC by Marcel de Rooy
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16501: Remove some unneeded warns in Upload.t (1.27 KB, patch)
2016-05-11 14:26 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16501: Remove some unneeded warns in Upload.t (1.28 KB, patch)
2016-05-11 19:03 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 16501: Remove some unneeded warns in Upload.t (1.35 KB, patch)
2016-05-13 20:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-05-11 14:19:57 UTC

    
Comment 1 Marcel de Rooy 2016-05-11 14:26:03 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2016-05-11 19:03:51 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-05-13 20:54:12 UTC
Created attachment 51487 [details] [review]
Bug 16501: Remove some unneeded warns in Upload.t

At some point I saw some gain in warning about a missing config line.
But these warns are actually not needed here.
Removing them here.

Test plan:
Run t/db_dependent/Upload.t while having upload_path in your koha-conf and
also without it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2016-05-16 17:46:47 UTC
Pushed to master for Koha 16.05, thanks Marcel!
Comment 5 Julian Maurice 2016-05-17 05:59:57 UTC
Patch pushed to 3.22.x, will be in 3.22.7