A staff borrower with catalogue and "parameters_remaining_permissions Remaining system parameters permissions" cannot save sysprefs. To recreate: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. You will see the following message: Error; your data might not have been saved You need to log in again, your session has timed out.
Created attachment 51573 [details] [review] Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save.
Created attachment 51928 [details] [review] Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 52057 [details] [review] Bug 16508: Updating a syspref requires parameters_remaining_permissions And not all of parameters flags. Test plan: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the November 2016 Release. Thanks
Pushed in 16.05. Will be in 16.05.01.
Patch pushed to 3.22.x, will be in 3.22.8