Bug 16516 - showListsUpdate JS function is not defined at the OPAC
Summary: showListsUpdate JS function is not defined at the OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 12233
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-13 18:25 UTC by Jonathan Druart
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16516: Define the showListsUpdate JS function at the OPAC (1.27 KB, patch)
2016-05-13 18:31 UTC, Jonathan Druart 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16516: Define the showListsUpdate JS function at the OPAC (1.38 KB, patch)
2016-05-13 21:52 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 16516: Define the showListsUpdate JS function at the OPAC (1.43 KB, patch)
2016-05-20 06:10 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-05-13 18:25:59 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2016-05-13 18:31:13 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 2
        

        
          Owen Leonard

        

        
        

        
          2016-05-13 21:52:49 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 3
        

        
          Marcel de Rooy

        

        
        

        
          2016-05-20 06:10:55 UTC
        

      






Created attachment 51633 [details] [review]
Bug 16516: Define the showListsUpdate JS function at the OPAC

Bug 12233 removes the declaration of the showListsUpdate JS function for
the OPAC.
It results in a JS error (ReferenceError: showListsUpdate is not
defined) when a user tries to add selected titles to a list if no title
is selected.

Test plan:
Launch a catalogue search
Select a list in the "Select titles to" dropdown list
=> Without this patch you will get the JS error
=> With this patch you will get a JS alert "No item was selected"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

    


    


      



        
          Comment 4
        

        
          Kyle M Hall (khall)

        

        
        

        
          2016-05-23 17:41:22 UTC
        

      






Pushed to master for Koha 16.05, thanks Jonathan!

    


    


      



        
          Comment 5
        

        
          Julian Maurice

        

        
        

        
          2016-05-25 09:26:14 UTC
        

      






Patch pushed to 3.22.x, will be in 3.22.7