Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab
Summary: Add the date on which the suggestion was managed on Purchase suggestions tab
Status: RESOLVED DUPLICATE of bug 24585
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Andreas Roussos
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-17 13:18 UTC by Marjorie Barry-Vila
Modified: 2020-07-31 08:27 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab (2.94 KB, patch)
2016-09-17 16:48 UTC, Andreas Roussos
Details | Diff | Splinter Review
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab (3.07 KB, patch)
2016-09-28 16:20 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marjorie Barry-Vila 2016-05-17 13:18:29 UTC
Hi,

It would be helpful if the date on wich the suggestion was managed was added on Purchase suggestions tab on borrower account.

There is just who managed the suggestion.

This can be as like date on table in suggestion.pl

Regards

Marjorie
Comment 1 Andreas Roussos 2016-09-17 16:48:24 UTC
Created attachment 55632 [details] [review]
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab

In the Staff client, under Patrons, the 'Purchase suggestions' tab for a
patron does not include the date on which the suggestion was managed. If
you follow a different route and go to Acquisitions > Suggestions, then
the date is shown.

This patch adds that enhancement (and fixes an open <td> tag, too).

Test plan:
0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit.
1) Go to Patrons and search for a patron whose suggestion has been managed.
   In the 'Purchase suggestions' tab for the patron, notice how the third
   column only lists _who_ managed the suggestion but not _when_.
2) Apply the patch.
3) Repeat step 1). The date the suggestion was managed should be displayed.
Comment 2 Marc Véron 2016-09-28 16:20:02 UTC
Created attachment 55894 [details] [review]
Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab

In the Staff client, under Patrons, the 'Purchase suggestions' tab for a
patron does not include the date on which the suggestion was managed. If
you follow a different route and go to Acquisitions > Suggestions, then
the date is shown.

This patch adds that enhancement (and fixes an open <td> tag, too).

Test plan:
0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit.
1) Go to Patrons and search for a patron whose suggestion has been managed.
   In the 'Purchase suggestions' tab for the patron, notice how the third
   column only lists _who_ managed the suggestion but not _when_.
2) Apply the patch.
3) Repeat step 1). The date the suggestion was managed should be displayed.

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2016-10-03 11:41:44 UTC
I think it would be better to add this info to its own column to allow sort on it, don't you think?
Comment 4 Jonathan Druart 2016-10-03 11:44:21 UTC
(In reply to Jonathan Druart from comment #3)
> I think it would be better to add this info to its own column to allow sort
> on it, don't you think?

Hum not sure actually, it's how it's displayed on the suggestion list page.
Comment 5 Marc Véron 2016-10-03 12:44:14 UTC
(In reply to Jonathan Druart from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > I think it would be better to add this info to its own column to allow sort
> > on it, don't you think?
> 
> Hum not sure actually, it's how it's displayed on the suggestion list page.

The way the patch displays the date is fine for me.

A date colum would be fine as well, but if we add a date column, we should do the same on the suggestion list page to have the same look & feel.
Comment 6 Owen Leonard 2016-10-03 12:48:45 UTC
I think the addition of a new column for the date would be a good change.
Comment 7 Jonathan Druart 2016-10-03 13:19:01 UTC
If we want to stick with this patch, we should fix the following bug:
If the date does not exist, the cell contains: "name - "
Comment 8 Marc Véron 2016-10-03 13:57:01 UTC
(In reply to Jonathan Druart from comment #7)
> If we want to stick with this patch, we should fix the following bug:
> If the date does not exist, the cell contains: "name - "

Can that ever happen? 
I had to delete the date directly in mysql to test this case (setting the date to '' and to NULL).
If there is no date, the column displays nothing (with and without patch).
On /suggestion/suggestion.pl, the column shows ' - ' (no name, no date, only the -)

But if somebody adds a date column, I'll be happy to sign off :-)
Comment 9 Jonathan Druart 2016-10-04 07:58:25 UTC
I have plenty of them and the check exist in suggestion.tt
Comment 10 Abbey Holt 2020-07-29 15:35:55 UTC
Our staff would love a sortable column for date managed and date suggested in the borrower view. Hopefully this is still a possibility!
Comment 11 Jonathan Druart 2020-07-31 08:27:50 UTC
This has been added by bug 24585.

*** This bug has been marked as a duplicate of bug 24585 ***