When attempting to avoid accidental deletion of items in Barcodes.t, I instead caused total deletion of items and issues
Created attachment 51689 [details] [review] Bug 16561 - Followup to fix tests When I altered the tests to avoid accidental deletion of all items, I didn't rollback the transaction, hence the tests now delete all items from a db when run. This patch rollsback the transaction so items are not deleted from your db To test: 1 - Backup your db 2 - prove -v t/db_dependent/Barcodes.t 3 - Note that all items and issues are deleted from the DB 4 - Restore your DB 5 - Apply this patch 6 - prove -v t/db_dependent/Barcodes.t 7 - Your DB should eb unchanged
Created attachment 51693 [details] [review] Bug 16561 - Bug 15877 followup to fix tests When I altered the tests to avoid accidental deletion of all items, I didn't rollback the transaction, hence the tests now delete all items from a db when run. This patch rollsback the transaction so items are not deleted from your db To test: 1 - Backup your db 2 - prove -v t/db_dependent/Barcodes.t 3 - Note that all items and issues are deleted from the DB 4 - Restore your DB 5 - Apply this patch 6 - prove -v t/db_dependent/Barcodes.t 7 - Your DB should eb unchanged Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have amended the patch to fix alignment and commit message (to display bug 15877). Skipping QA as it's a trivial one.
Pushed to master for Koha 16.05, thanks Nick!
Patch pushed to 3.22.x, will be in 3.22.7