The following sentence needs a better wording to avoid translation problems: Pending for next available <i>[% ItemTypes.GetDescription( RESERVE.itemtype ) %]</i> item
Created attachment 51716 [details] [review] Bug 16562: Translatability: Issue in opac-user.tt (separated word 'item') This patch fixes translatoion difficulties (syntax) with a tag-separated word 'item'
Created attachment 51849 [details] [review] [SIGNED-OFF] Bug 16562: Translatability: Issue in opac-user.tt (separated word 'item') This patch fixes translatoion difficulties (syntax) with a tag-separated word 'item' Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors
Not sure it will make the translation easier, but I don't have something else to suggest. Letting it here to get another QA point of view.
Why don't you just remove the i tag and surround the whole sentence with a span?
(In reply to Jonathan Druart from comment #3) > Not sure it will make the translation easier, but I don't have something > else to suggest. > Letting it here to get another QA point of view. I'll add a : to the text to make clear that a value will follow. It will read: Pending for next available item of type: Book (Book in italic) That is nicer because item types start with a capital letter.
Created attachment 52230 [details] [review] Bug 16562: (Follow-up) Add ':' to enhance readability and translatability The text will now read: Pending for next available item of type: Book (Book in italic) This is nicer because item types normally start with a capital letter and because it will be clearer in translation that a value will follow. See comments #5
(In reply to Jonathan Druart from comment #4) > Why don't you just remove the i tag and surround the whole sentence with a > span? And what about this suggestion?
It would read: Pending for next available item of type Book I like it better the way I did it, for the reason I explained in my comment. Pending for next available item of type: <i>Book</i>
(In reply to Marc Véron from comment #8) > It would read: > Pending for next available item of type Book > > I like it better the way I did it, for the reason I explained in my comment. > Pending for next available item of type: <i>Book</i> I meant: Pending for next available Book item. i.e. same wording as before
(In reply to Jonathan Druart from comment #9) > (In reply to Marc Véron from comment #8) > > It would read: > > Pending for next available item of type Book > > > > I like it better the way I did it, for the reason I explained in my comment. > > Pending for next available item of type: <i>Book</i> > > I meant: > Pending for next available Book item. > > i.e. same wording as before In Pootle, that would be: Pending for next available %s item. Translaters would have to find out what the %s stands for, that's why IMO my solution is better.
I let this one for someone else, but I am pretty sure we could find something better.
Hm, thinking of other ways to format this. One thing standing out to me is the 'type', I'd like it better to use 'item of item type' to be very clear what this type thing is about :) Suggestion: Pending for next available item of item type '[% ItemTypes.GetDescription( RESERVE.itemtype ) %]'
Created attachment 52552 [details] [review] Bug 16562 - Translatability: Issue in opac-user.tt (separated word 'item') Alternate patch with wording as proposed in comment #12
Created attachment 52819 [details] [review] Bug 16562 - Translatability: Issue in opac-user.tt (separated word 'item') Alternate patch with wording as proposed in comment #12 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.02.
Not needed in 3.22.x