Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action.
Created attachment 51719 [details] [review] Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected
Patch tested with a sandbox, by Jonathan Field <jonathan.field@ptfs-europe.com>
Created attachment 63529 [details] [review] Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>
Created attachment 63564 [details] [review] Bug 16568 - Talking Tech generates phone notifications for all overdue actions Regardless of whether the phone transport has been selected for a given overdue action or not, the Talking Tech outbound script generates and sends a line for that action. Test Plan: 1) Enable Talking Tech 2) Create one or more overdue actions without a phone transport selected and one or more with the phone transport selected 3) Generate the overdues csv file to send to Itive 4) Note the csv file has lines for actions that do not have the phone transport selected 5) Apply this patch 6) Repeat step 3 7) Note the csv file now only has lines for actions that have the phone transport selected Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Looks good to me (trivial change). Another point is moving these larger queries out of the scripts.
Pushed to master for 17.05!
This patch has been pushed to 16.11.x and will be in 16.11.08.
Pushed to 3.22.x for 3.22.21
Pushed to 16.05.x, for 16.05.13 release