Update and translate sample SQL file of the Italinan installer.
To test: - Start with an empty database - Install it-IT - Run the web installer in it-IT/Italian - Verify all files, especially sample notices, sample_frequencies, sample_numberpatterns load without any problems.
Created attachment 51836 [details] [review] Update Italian installer sample files
Created attachment 51837 [details] [review] Followup of the patch
Created attachment 53725 [details] [review] Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). NOTE: Squashed both patches. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This is not an enhancement. This is a bug fix, as many of the strings in the Italian SQL files were English to start with. Marking it as such.
Comment on attachment 53725 [details] [review] Bug 16585: Update Italian installer sample files for 16.05 Review of attachment 53725 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/it-IT/necessari/notices.sql @@ +7,5 @@ > ('circulation','DUEDGST','Avviso restituzione (digest)','Avviso restituzione (digest)','Hai <<count>> prestiti da retituire', 'email'), > ('circulation','PREDUE','Preavviso scadenza prestito','Preavviso scadenza prestito','Salve <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nQuesti prestiti stanno per scadere:\r\n\r\n<<biblio.title>>, <<biblio.author>> (<<items.barcode>>)', 'email'), > +('circulation','PREDUEDGST','Preavviso scadenza prestiti (digest)','Avviso copie in scadenza','Gentile <<borrowers.firstname>> <<borrowers.surname>>, > +Il prestito dei seguenti volumi sta per scadere: > + You should use \r\n to line breaks. ::: installer/data/mysql/it-IT/necessari/sample_frequencies.sql @@ +1,2 @@ > INSERT INTO subscription_frequencies > + (id, description, displayorder, unit, unitsperissue, issuesperunit) Why do you force the id? ::: installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql @@ +1,2 @@ > INSERT INTO subscription_numberpatterns > + (id, label, displayorder, description, numberingmethod, Same here. ::: installer/data/mysql/it-IT/necessari/system_preferences.sql @@ +20,4 @@ > UPDATE systempreferences SET value = '1' WHERE variable = 'AllowRenewalLimitOverride'; > UPDATE systempreferences SET value = 'annual' WHERE variable = 'autoBarcode'; > UPDATE systempreferences SET value = 'email' WHERE variable = 'AutoEmailPrimaryAddress'; > +UPDATE systempreferences SET value = '1' WHERE variable = 'BiblioAddsAuthorities'; The changes in this file seems very specific but nobody complain until now, so that should be ok.
Hi, I answer the request of Jonathan (#6): >You should use \r\n to line breaks. I insert "\r\n\r\n" because in Italy we want a empty line in the template. It is a cosmetic request. I used "\r\n\r\n" in older version of notices.sql >Why do you force the id? [in sample_frequencies.sql and in > sample_numberpatterns.sql] In fact I insert ids only because I create file directly wirh mysql tools. I think we can not insert them. >The changes in this file [system_preferences.sql] seems very specific > but nobody complain until now, so that should be ok. I try to guess the best default for italian users.
Created attachment 53882 [details] [review] Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(In reply to Zeno Tajoli from comment #7) > Hi, > I answer the request of Jonathan (#6): > > >You should use \r\n to line breaks. > I insert "\r\n\r\n" because in Italy we want a empty line in the template. > It is a cosmetic request. > I used "\r\n\r\n" in older version of notices.sql No, look at: +Il prestito dei seguenti volumi sta per scadere: + +<<items.content>> + +<<branches.branchname>>', 'email'), You did not use \r\n or whatever. Anyway, it's fine by me.
pushed to master - Should be in the November 2016 - Thanks!