On the acquisitions receipt summary page the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Created attachment 51835 [details] [review] Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders.
Created attachment 51930 [details] [review] Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc Véron <veron@veron.ch>
Owen, The page is reloaded when I close the modal, is it expected?
(In reply to Jonathan Druart from comment #3) > Owen, > The page is reloaded when I close the modal, is it expected? Oops, forget that, it's the "close" link of the plack debug block
Created attachment 52165 [details] [review] Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for Koha 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.01.