Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> NOTE: Wiki needs to be updated -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received"
Created attachment 51841 [details] [review] Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report
(In reply to Héctor Eduardo Castro Avalos from comment #1) > NOTE: Wiki needs to be updated I have updated the wiki.
Created attachment 51880 [details] [review] Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana <s.paltineanu@berlin.bard.edu>
Still applies...
Created attachment 52256 [details] [review] Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana <s.paltineanu@berlin.bard.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 52257 [details] [review] Bug 16594: Fix obvious QA issues from bug 11371 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for Koha 16.11, thanks Hector, Jonathan!
Pushed in 16.05. Will be in 16.05.01.
Not needed in 3.22.x